fix(color-contrast): correctly compute color-contrast of truncated children #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Oct 13, 2021
| * Assumes that |parent| is an ancestor of |node|. | ||
| * @param {Element} node | ||
| * @param {Element} parent | ||
| * @return {boolean} True if node is visually contained within parent | ||
| */ | ||
| function contains(node, parent) { | ||
| const rectBound = node.getBoundingClientRect(); | ||
| const margin = 0.01; |
There was a problem hiding this comment.
Why did you remove the margin?
There was a problem hiding this comment.
Why do we need the margin?
There was a problem hiding this comment.
If that's the case, I would rather use Math.ceil and Math.floor to handle rounding issues rather than use a magic number. It makes it way more clear what the intent is.
| ); | ||
| var expected = new axe.commons.color.Color(0, 255, 0, 1); | ||
| document.documentElement.style.background = orig; | ||
| assert.isNull(actual); |
There was a problem hiding this comment.
Wow... That's all I have to say about this.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…core into visually-contains
straker
changed the title
WilcoFiers
previously approved these changes
Oct 14, 2021
straker
changed the title
WilcoFiers
previously requested changes
Oct 15, 2021
WilcoFiers
approved these changes
Oct 18, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
…ildren (#3203) * fixes * finalize * sort * test * fix tests * Update lib/commons/color/get-background-stack.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * fixes * split out pr * order * rounding Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is dependent on #3207
The
visuallyContainscode was hard to understand what it was doing, so I refactored it to simplify it. Now it doesn't need to do thescrollTopandscrollLeftchecking and only does a single compare to determine if the element is fully inside the other.Closes issue: #2669